Add TaskValidation module #235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratsclub
force-pushed
the
task-validation
branch
from
5d9cf46 to
2ec82b5
Compare
ratsclub
force-pushed
the
task-validation
branch
from
2ec82b5 to
e062068
Compare
TheAngryByrd
requested changes
Nov 14, 2023
tests/FsToolkit.ErrorHandling.TaskResult.Tests/TaskValidation.fs
Outdated
Show resolved
Hide resolved
| [<AutoOpen>] | ||
| module TaskValidationCE = | ||
|
|
||
| type TaskValidationBuilder() = |
There was a problem hiding this comment.
Seems to be missing the ResumableStateMachine. See how TaskResult is implemented.
There was a problem hiding this comment.
I have never dealt with this before, I'll read about it and try to implement it.
ratsclub
force-pushed
the
task-validation
branch
from
209efa0 to
5304fd0
Compare
|
👋 I'm gonna close this since there hasn't been movement in a year. Also TaskResults have moved to the core library if you feel motivated to give this another go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This is a PR for: #228. It adds the
TaskValidationmodule.Types of changes
What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an
xin the boxes that apply and remove ones that don't applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...