Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Algorithm in a Box inside Minimizer #42

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Store Algorithm in a Box inside Minimizer #42

merged 3 commits into from
Oct 21, 2024

Conversation

denehoffman
Copy link
Owner

Also adds Minimizer::new_from_box to easily construct Minimizers from Box<dyn Algorithm>

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.37%. Comparing base (97dacca) to head (c43c8de).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/lib.rs 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   70.12%   70.37%   +0.24%     
==========================================
  Files           8        8              
  Lines        1811     1826      +15     
==========================================
+ Hits         1270     1285      +15     
  Misses        541      541              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Benchmark for 786b699

Click to view benchmark
Test Base PR %
nelder-mead: rosenbrock/Adaptive/2 33.1±0.37µs 32.8±0.49µs -0.91%
nelder-mead: rosenbrock/Adaptive/3 85.3±2.04µs 85.2±1.22µs -0.12%
nelder-mead: rosenbrock/Adaptive/4 166.4±3.91µs 167.1±5.01µs +0.42%
nelder-mead: rosenbrock/Adaptive/5 264.8±4.90µs 266.4±5.43µs +0.60%
nelder-mead: rosenbrock/Standard/2 33.3±0.56µs 32.7±0.72µs -1.80%
nelder-mead: rosenbrock/Standard/3 70.3±1.85µs 70.7±1.00µs +0.57%
nelder-mead: rosenbrock/Standard/4 144.7±2.42µs 145.8±1.49µs +0.76%
nelder-mead: rosenbrock/Standard/5 241.3±10.44µs 240.8±1.98µs -0.21%

@denehoffman denehoffman merged commit 5d9f80b into main Oct 21, 2024
6 checks passed
@denehoffman denehoffman deleted the more_boxes branch October 21, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant