Change default tolerances to be a bit more realistic #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default epsilon values for basically all the methods were a bit too precise. While they work fine for the Rosenbrock demos, most real-world applications don't start with that level of precision (scipy uses 1e-4 for both tolerances on their Nelder-Mead and esp * 1e7 for their 64-bit float tolerance for L-BFGS-B, for example). I've tried to scale these and use values that can work with either 64- or 32-bit floats and approximate those used by the 64-bit only existing libraries (scipy and the FORTRAN implementation of L-BFGS-B). As a result, tests needed to be updated (in precision only) and benchmarks will probably run faster simply because it will take fewer steps to converge.