Remove dependency on colored #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
rm-colored
branch
from
0b06871 to
57b069f
Compare
denisdefreyne
added a commit
to nanoc/nanoc
that referenced
this pull request
Apr 29, 2019
Cri used to have a dependency on `colored`, which Nanoc made implicit use of. Cri no longer has that dependency (see denisdefreyne/cri#90), which broke Nanoc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89.
Rather than using
colored(or any other gem) to provide us with ANSI escape codes, let’s generate the ANSI escape codes ourselves. (They’re quite easy to generate.)