Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape-change op testing #11

Draft
wants to merge 16 commits into
base: dgkutnic/xla-wip
Choose a base branch
from
Draft

Conversation

jd-bartlett96
Copy link
Collaborator

@jd-bartlett96 jd-bartlett96 commented Jul 31, 2020

Testing for Broadcast, Reshape, Pad, and Slice
EDIT: and Transpose

To-do:

  • Figure out better method for constant padding value evaluation
  • Debug Symmetric/reflect padding
  • Test slice

@jd-bartlett96 jd-bartlett96 requested a review from denise-k July 31, 2020 16:45
@jd-bartlett96 jd-bartlett96 marked this pull request as draft July 31, 2020 23:13
@jd-bartlett96 jd-bartlett96 marked this pull request as ready for review August 3, 2020 18:17
@jd-bartlett96 jd-bartlett96 changed the title WIP: Shape-change op testing Shape-change op testing Aug 3, 2020
@jd-bartlett96
Copy link
Collaborator Author

Lingering issue: Reflect and Symmetric paddings still fail on PlaidML compiler optimization passes; a manual construction of symmetric padding using tf.slice+tf.reverse+tf.concatenate works fine

@jd-bartlett96 jd-bartlett96 marked this pull request as draft August 5, 2020 20:13
@jd-bartlett96
Copy link
Collaborator Author

Note, the branch is currently referencing a sub-branch of PlaidML; this reference should be fixed before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant