Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tx interface for go1.8 #193

Closed
kardianos opened this issue Dec 14, 2016 · 2 comments
Closed

Update Tx interface for go1.8 #193

kardianos opened this issue Dec 14, 2016 · 2 comments

Comments

@kardianos
Copy link
Collaborator

kardianos commented Dec 14, 2016 •
edited
Loading

Previously method was named DB.BeginContext, is now DB.BeginTx .
Need to update interface for go1.8 release support.

https://go.googlesource.com/go/+/d0501f1da9c54a8053940feeb86e1644ffaae522
@AlekSi AlekSi mentioned this issue Dec 14, 2016
Closed
@mirza-s
Copy link

mirza-s commented Dec 15, 2016

Also in go1.8beta2 compilation fails because these methods are removed:

# github.com/denisenkom/go-mssqldb
../github.com/denisenkom/go-mssqldb/mssql_go18.go:21: undefined: driver.ReadOnlyFromContext
../github.com/denisenkom/go-mssqldb/mssql_go18.go:25: undefined: driver.IsolationFromContext

@kardianos
Copy link
Collaborator Author

Yes, they were moved to the TxOptions struct.

kardianos added a commit that referenced this issue Dec 16, 2016
@kardianos
mssql: update to latest go1.8 BeginTx
952fdfc 
Fixes #193
@kardianos kardianos mentioned this issue Dec 16, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kardianos @mirza-s