Fix potential race condition bug #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you |
dimdin
added a commit
that referenced
this pull request
Oct 19, 2015
Fix potential race condition bug
odeke-em
pushed a commit
to orijtech/go-mssqldb
that referenced
this pull request
Jul 26, 2020
Update README to reflect epoch filenames
odeke-em
pushed a commit
to orijtech/go-mssqldb
that referenced
this pull request
Jul 26, 2020
Refactor cli package to allow `go get` one-liner with a proper binary name
gabrielcorado
pushed a commit
to gravitational/go-mssqldb
that referenced
this pull request
Oct 4, 2024
fix: protocol version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While re-using this code in another application I realised that there is a potential bug. It might be possible for one IP address to return an error before another one returns a successful connection, in which case the error handling code would have caused the connection to be ignored. This never happened to occur in the availability group because the non-primary listeners would take a while to time out. Don't want to depend on that, though.