added a check to net.Error.Timeout() before returning driver.ErrBadConn #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merged, thanks! |
|
I am getting error: Running netstat, I don't see any connection attempt from it, nor putting wrong credentials show login error in sql server logs Running Windows Server 2008 R2 with SQL Server EXPRESS 2005 It works with SQL Server 2008 |
odeke-em
pushed a commit
to orijtech/go-mssqldb
that referenced
this pull request
Jul 26, 2020
Add mongodb driver to Dockerfile
gabrielcorado
pushed a commit
to gravitational/go-mssqldb
that referenced
this pull request
Oct 4, 2024
* Update dependencies * support dataverse endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this doesn't necessary close #134 or #105 but I think it will help troubleshoot in the future and addresses problems that were brought up in both issue threads.
net.Error has a method .Timeout() that returns a bool if the error was because of an expired timeout. I added a check before the return of the driver.ErrBadConn.