Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure to call cancel func #544

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Conversation

skaji
Copy link
Contributor

@skaji skaji commented Nov 27, 2019

Currently, go vet reports:

❯ go vet 2>&1 | grep mssql.go
./mssql.go:596:2: the cancel function is not used on all paths (possible context leak)
./mssql.go:616:5: this return statement may be reached without using the cancel var defined on line 596

This PR fixes these.

@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #544 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #544      +/-   ##
=========================================
+ Coverage   68.89%   68.9%   +0.01%     
=========================================
  Files          22      22              
  Lines        5066    5068       +2     
=========================================
+ Hits         3490    3492       +2     
  Misses       1370    1370              
  Partials      206     206
Impacted Files Coverage Δ
mssql.go 82.77% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7327370...60c69af. Read the comment docs.

@denisenkom denisenkom merged commit 1d7a30a into denisenkom:master Nov 28, 2019
rHermes pushed a commit to vippsas/go-mssqldb that referenced this pull request Mar 30, 2020
rHermes added a commit to vippsas/go-mssqldb that referenced this pull request Mar 31, 2020
rHermes added a commit to vippsas/go-mssqldb that referenced this pull request Jul 29, 2020
rHermes added a commit to vippsas/go-mssqldb that referenced this pull request Jul 29, 2020
rHermes added a commit to vippsas/go-mssqldb that referenced this pull request Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants