Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prelogin and Login handling for TDS74 FederatedAuth with Security Token #166

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

bowleri
Copy link

@bowleri bowleri commented Jul 11, 2024

Fixes #135

@bowleri bowleri mentioned this pull request Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 95.37572% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.19%. Comparing base (585547b) to head (ea3f618).

Files Patch % Lines
src/pytds/tds_session.py 95.18% 4 Missing ⚠️
tests/all_test.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   89.10%   89.19%   +0.09%     
==========================================
  Files          44       44              
  Lines        8095     8240     +145     
==========================================
+ Hits         7213     7350     +137     
- Misses        882      890       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bowleri
Copy link
Author

bowleri commented Jul 19, 2024

Appveyor update of ruff from ruff-0.5.1 to ruff-0.5.3 has created failures in tds_types.py

@denisenkom
Copy link
Owner

Hi @bowleri, thank you for this pull request. I have some questions below.

How can I test this? Maybe you can give me a simple example script that generates access token and nonce, that I could then use against my test Azure account.

It also seems couple validations are missing, can you add those validations?:

  • It should fail connection attempt if access_token was provided but server is not supporting TDS 7.4
  • It should fail if access_token was provided but contained an empty string

I noticed that you convert access_token into ASCII byte string, this assumes that access_token contains only ASCII characters. Is this assumption safe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Support for token based Authentication for Azure SQL
3 participants