-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prelogin and Login handling for TDS74 FederatedAuth with Security Token #166
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 89.10% 89.19% +0.09%
==========================================
Files 44 44
Lines 8095 8240 +145
==========================================
+ Hits 7213 7350 +137
- Misses 882 890 +8 ☔ View full report in Codecov by Sentry. |
Appveyor update of ruff from ruff-0.5.1 to ruff-0.5.3 has created failures in tds_types.py |
…ogin7, move feature extension to match auth_packet offset
Hi @bowleri, thank you for this pull request. I have some questions below. How can I test this? Maybe you can give me a simple example script that generates access token and nonce, that I could then use against my test Azure account. It also seems couple validations are missing, can you add those validations?:
I noticed that you convert access_token into ASCII byte string, this assumes that access_token contains only ASCII characters. Is this assumption safe? |
Fixes #135