-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Product Ads to version 3 #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisneuf
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, I will just add the changes in the main README file to let users find directly the endpoints that the api currently support
Great job @HamzaChx |
Great! Only thing left are keywords and product targeting. I should be able to add the changes soon. |
I will push some changes in the rst documents:
/Users/hanuman/Documents/PycharmProjects/python-amazon-ad-api-dev/source/sp/product_ads_v3.rst:2: WARNING: Title underline too short.
Product Ads
=========
WARNING: autodoc: failed to import function 'ProductAdsV3.create_campaigns' from module 'ad_api.api.sp'; the following exception was raised:
No module named 'ad_api.api.sp.ProductAdsV3'
WARNING: autodoc: failed to import function 'ProductAdsV3.edit_campaigns' from module 'ad_api.api.sp'; the following exception was raised:
No module named 'ad_api.api.sp.ProductAdsV3'
WARNING: autodoc: failed to import function 'ProductAdsV3.list_campaigns' from module 'ad_api.api.sp'; the following exception was raised:
No module named 'ad_api.api.sp.ProductAdsV3'
WARNING: autodoc: failed to import function 'ProductAdsV3.delete_campaigns' from module 'ad_api.api.sp'; the following exception was raised:
No module named ‘ad_api.api.sp.ProductAdsV3'
The methods was wrong as belongs to the Campaign endpoint, need to be updated to the specific method of the current endpoint
Also will push the updated _init_.py that allows to path the new endpoints
from .campaigns import Campaigns
from .campaigns_v3 import CampaignsV3
from .ad_groups import AdGroups
from .ad_groups_v3 import AdGroupsV3
from .product_ads import ProductAds
from .product_ads_v3 import ProductAdsV3
from .bid_recommendations import BidRecommendations
from .keywords import Keywords
from .negative_keywords import NegativeKeywords
from .campaign_negative_keywords import CampaignNegativeKeywords
from .suggested_keywords import SuggestedKeywords
from .product_targeting import Targets
from .negative_product_targeting import NegativeTargets
from .reports import Reports
from .snapshots import Snapshots
from .budget_rules import BudgetRules
from .campaings_optimization import CampaignOptimization
from .ranked_keywords_recommendations import RankedKeywordsRecommendations
from .budget_recommendations import BudgetRecommendations
from .budget_rules_recommendations import BudgetRulesRecommendations
from .product_recommendations import ProductRecommendations
…__all__ = [
"Campaigns",
"CampaignsV3",
"AdGroups",
"AdGroupsV3"
"ProductAds",
"ProductAdsV3"
"BidRecommendations",
"Keywords",
"NegativeKeywords",
"CampaignNegativeKeywords",
"SuggestedKeywords",
"Targets",
"NegativeTargets",
"Reports",
"Snapshots",
"BudgetRules",
"CampaignOptimization",
"RankedKeywordsRecommendations",
"BudgetRecommendations",
"BudgetRulesRecommendations",
"ProductRecommendations"
]
You can pull it later in a while.
El 3 abr 2023, a las 23:17, Hamza ***@***.***> escribió:
Great!
—
Reply to this email directly, view it on GitHub <#132 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD4ENUXVGRFIFUDNVTQITTLW7LSY7ANCNFSM6AAAAAAWROGFYA>.
You are receiving this because you modified the open/close state.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New endpoints for product ads, check : ad_api/api/sp/product_ads_v3.py