Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Product Ads to version 3 #132

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

HamzaChx
Copy link
Collaborator

@HamzaChx HamzaChx commented Apr 3, 2023

New endpoints for product ads, check : ad_api/api/sp/product_ads_v3.py

  • adding the new endpoints to product_ads_v3.py
  • adding the @Utils.deprecated to v2 of product ads
  • changes to the docs

@HamzaChx HamzaChx requested a review from denisneuf April 3, 2023 15:01
@HamzaChx HamzaChx linked an issue Apr 3, 2023 that may be closed by this pull request
Copy link
Owner

@denisneuf denisneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, I will just add the changes in the main README file to let users find directly the endpoints that the api currently support

@denisneuf denisneuf merged commit 4ae6366 into denisneuf:main Apr 3, 2023
@denisneuf
Copy link
Owner

Great job @HamzaChx

@HamzaChx
Copy link
Collaborator Author

HamzaChx commented Apr 3, 2023

Great! Only thing left are keywords and product targeting. I should be able to add the changes soon.

@denisneuf
Copy link
Owner

denisneuf commented Apr 3, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating SP Product Ads to Version 3
2 participants