Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix serialize bug in #344 #433

Merged
merged 6 commits into from
Feb 12, 2019
Merged

fix serialize bug in #344 #433

merged 6 commits into from
Feb 12, 2019

Conversation

ekinakyurek
Copy link
Collaborator

After Julia fixed deepcopy bug, I fix our serialization bug too.

After Julia fixed deepcopy bug in, I fix our bug too.
@denizyuret
Copy link
Owner

#425 ve #433 icin simdi fail eden duzeltmeden sonra gecen test lazim...

@ekinakyurek
Copy link
Collaborator Author

I merged with #425 and added the tests that fails before

@ekinakyurek
Copy link
Collaborator Author

ekinakyurek commented Feb 12, 2019

@denizyuret could you try below snippet by activating this project https://github.com/ekinakyurek/Morse.jl/tree/predict on a cpu only machine, which requires internet connection to download the saved model:

julia> using Knet, KnetLayers , Morse
julia> model, vocabulary, parser = trained(MorseModel, TRDataSet, vers="2018");
julia> predictions = model("annem sana yardım edemez .", v=vocabulary, p=parser)

I'm getting assertion error on size of hidden states, whereas I don't get any error on a GPU machine.

@denizyuret
Copy link
Owner

```julia
julia> using Knet, KnetLayers , Morse
julia> model, vocabulary, parser = trained(MorseModel, TRDataSet, vers="2018");
julia> predictions = model("annem sana yardım edemez .", v=vocabulary, p=parser)

You had a 2-D hidden state instead of 3-D. I modified the code so the assertion ignores trailing 1 dimensions.

@denizyuret denizyuret merged commit cd2498e into master Feb 12, 2019
@denizyuret denizyuret deleted the serialize branch September 1, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants