Prevent debuggers from stepping into Pathy code#88
Merged
dennisdoomen merged 1 commit intomainfrom Oct 19, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds DebuggerNonUserCode to internal Pathy types when compiled without PATHY_PUBLIC to reduce debugger stepping into library internals.
- Marked internal versions of core types and extension classes with DebuggerNonUserCode
- Left public versions (when PATHY_PUBLIC is defined) unchanged
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Pathy/ChainablePathExtensions.cs | Adds DebuggerNonUserCode to the internal extension class under non-PATHY_PUBLIC builds |
| Pathy/ChainablePath.cs | Adds DebuggerNonUserCode to the internal ChainablePath record and internal StringExtensions class under non-PATHY_PUBLIC builds |
| Pathy.Globbing/PathyGlobbing.cs | Adds DebuggerNonUserCode to the internal globbing extension class under non-PATHY_PUBLIC builds |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Pull Request Test Coverage Report for Build 18627285007Details
💛 - Coveralls |
This was referenced Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
[DebuggerNonUserCode]attribute to several classes in the Pathy library to improve the debugging experience. The attribute prevents debuggers from stepping into these classes when developers are debugging their own code, treating them as framework/library code that users typically don't want to debug through. This is particularly useful since Pathy appears to be a path manipulation utility library that gets embedded into other projects, and developers using it would prefer to step over its internal implementation details rather than into them during debugging sessions. The change affects the main path handling classes and extension methods, making debugging more focused on user code rather than the library's internals.Fixes #85