-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth plugin caching sha2 password #68
Auth plugin caching sha2 password #68
Conversation
backup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
At present, this feature needs to be verified by testing
For the feature of configuring publicKey, it may be good to do it in the new PR, because testing it requires more changes to CI and test cases |
Agree, should we also add these plans to our TODO. |
Of course this is the best |
It works on mysql8 with caching sha2 enabled on my computer. |
This PR also solved the "Got packets out of order" problem I had. Great work! |
"It works on mysql8 with caching sha2 enabled on my computer." How? Where? How's this working? Where do I find it working? |
It's related about #16
Currently it works for both mysql 8.0 and mysql 5.6 based on my test.
But it just works. There is still work left to completely support mysql8.0. In further, we need to:
and others I doesn't figure out now.
Anyway, please help to check this PR and give me feedbacks. Thanks!