Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth plugin caching sha2 password #68

Merged

Conversation

wenjoy
Copy link
Collaborator

@wenjoy wenjoy commented Aug 9, 2020

It's related about #16

Currently it works for both mysql 8.0 and mysql 5.6 based on my test.
But it just works. There is still work left to completely support mysql8.0. In further, we need to:

  • support negotiation of auth method if mismatched
  • used configured public key
    and others I doesn't figure out now.

Anyway, please help to check this PR and give me feedbacks. Thanks!

@wenjoy wenjoy requested review from manyuanrong and magichim August 9, 2020 03:42
src/connection.ts Outdated Show resolved Hide resolved
Copy link
Member

@manyuanrong manyuanrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
At present, this feature needs to be verified by testing

@manyuanrong
Copy link
Member

For the feature of configuring publicKey, it may be good to do it in the new PR, because testing it requires more changes to CI and test cases

@wenjoy
Copy link
Collaborator Author

wenjoy commented Aug 12, 2020

For the feature of configuring publicKey, it may be good to do it in the new PR, because testing it requires more changes to CI and test cases

Agree, should we also add these plans to our TODO.

@manyuanrong
Copy link
Member

Agree, should we also add these plans to our TODO.

Of course this is the best

@invisal
Copy link

invisal commented Aug 14, 2020

It works on mysql8 with caching sha2 enabled on my computer.

@robinbertram
Copy link

This PR also solved the "Got packets out of order" problem I had. Great work!

@manyuanrong manyuanrong merged commit 95e405e into denodrivers:master Jan 11, 2021
@suchislife801
Copy link

"It works on mysql8 with caching sha2 enabled on my computer."

How? Where? How's this working? Where do I find it working?

@lideming lideming mentioned this pull request Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants