move to jsr for dependencies and modernize some things #487
Conversation
|
merge main to your branch again |
williamhorning
force-pushed
the
jsr-and-modern-code
branch
from
341f200 to
d17c6e3
Compare
|
@bombillazo can you take a look at this again? I merged the branches again and added a few changes to deal with Deno 2 as well. Additionally, the tests which failed here passed locally, so it seems as though something is off with Github Actions |
| @@ -679,8 +683,7 @@ export class Connection { | |||
|
|
|||
| const buffer = this.#packetWriter.addCString(query.text).flush(0x51); | |||
|
|
|||
| await this.#bufWriter.write(buffer); | |||
| await this.#bufWriter.flush(); | |||
| await this.#connWritable.write(buffer); | |||
There was a problem hiding this comment.
Why are we no longer flushing the writer?
There was a problem hiding this comment.
we aren't flushing the writer anymore since the original code was flushing the data from the BufWriter class (from @std/io) to the underlying Deno.Writer, but since we're not using either of those and are using normal web streams here, awaiting the write seems to be fine in making sure everything gets written
|
@bombillazo is there any chance you can run the workflows for the latest commit here? |
This pr renames the jsr package so that it uses the @db scope (used by the mongo and sqlite drivers), moves the dependency on the standard library over to the jsr ones, updates those dependencies, and replaces code that relies on deprecated functions. The following three tests are still failing but I'm not too sure quite how to fix them:
I'd like to definitely fix the second test as that one isn't expecting an error and is getting an error, while the other two are failing due to errors not matching the ones expected.