Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement CLIENT CACHING #188

Merged
merged 4 commits into from
Feb 19, 2021
Merged

feat: Implement CLIENT CACHING #188

merged 4 commits into from
Feb 19, 2021

Conversation

craigpastro
Copy link
Contributor

Part of #174.

Hello 👋 . Two changes in this PR:

  1. Implement afterEach in the test suite and added creating the client connection to a beforeEach in connection_test and client.close() to afterEach. I think some of the effects of client tracking were affecting some of the tests in client caching.
  2. Implement client caching

If you like 1. would it be better to do it in a separate PR?

@craigpastro craigpastro changed the title feat: Implement client caching feat: Implement CLIENT CACHING Feb 18, 2021
uki00a
uki00a requested changes Feb 18, 2021
View reviewed changes
Copy link
Member

@uki00a uki00a left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing this feature!
Overall, everything looks good to me! A small nitpick:

Use finally for test suite afterEach
b1c6c6c 
Update based on feedback
uki00a
uki00a approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@uki00a uki00a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 👍

@uki00a uki00a merged commit b2f948c into denodrivers:master Feb 19, 2021
@uki00a uki00a mentioned this pull request Feb 19, 2021
Open
16 tasks
@craigpastro craigpastro deleted the impl-client-caching branch February 19, 2021 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uki00a uki00a uki00a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craigpastro @uki00a