added username+password auth support #310
Merged
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uki00a
requested changes
Jun 3, 2022
| @@ -24,6 +24,7 @@ export interface RedisConnectionOptions { | |||
| tls?: boolean; | |||
| db?: number; | |||
| password?: string; | |||
There was a problem hiding this comment.
Could you run deno fmt on this file?
$ deno fmt connection.tsThere was a problem hiding this comment.
done and fixed, pushing shortly darn deno fmt bit me again...
|
there ya go, sorry about that |
uki00a
approved these changes
Jun 3, 2022
|
tx, look forward to it.
…On Jun 3 2022, at 2:38 pm, Yuki Tanaka ***@***.***> wrote:
@uki00a approved this pull request.
LGTM, thanks for the contribution! 👍
I'll release a new version in the coming days
—
Reply to this email directly, view it on GitHub (#310 (review)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/ATXWUNUHO2NH56NHSYTNDNLVNIDF5ANCNFSM5XYBIITA).
You are receiving this because you were mentioned.
|
|
Released in v0.26.0! |
|
great to know, will look at other PR and Issues tomorrow, see where else I can help.
…On Jun 4 2022, at 1:26 pm, Yuki Tanaka ***@***.***> wrote:
Released in v0.26.0 (https://github.com/denodrivers/redis/releases/tag/v0.26.0)!
—
Reply to this email directly, view it on GitHub (#310 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/ATXWUNXMGDFKKXZ5HSROGRTVNNDOTANCNFSM5XYBIITA).
You are receiving this because you were mentioned.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #300
You can now use redis client with cloud hosted redis (redis enterprise/cloud stack) or any other redis server that has user+password authentication.
PR is not breaking, but has changed RedisConnectionOptions to support an optional username: string property.
Tests not included since, only tests that make sense require a redis instances setting up with:
I did not see mock redis server for this in tests, and existing test for authentication is only checking if a parameter has been passed and is valid. Which exception handling catches anyway.
ps. been a while since I did a PR. (also note, I have this code in production, be nice to use official repo for this. )