Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): enable no-console rule #423

Merged
merged 2 commits into from
Feb 17, 2024
Merged

chore(lint): enable no-console rule #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5a78f0
chore(lint): enable `no-console` rule
uki00a Feb 17, 2024
3cea32d
chore: lint
uki00a Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion deno.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"exclude": [
"benchmark/benchmark.js",
"benchmark/ioredis.js"
]
],
"rules": { "include": ["no-console"] }
},
"test": {
"exclude": ["benchmark/", "tmp/", "vendor/"]
Expand Down
3 changes: 2 additions & 1 deletion experimental/cluster/mod.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,8 @@ class ClusterExecutor implements CommandExecutor {
try {
await conn.quit();
} catch (err) {
console.error(err); // TODO: Improve logging
// deno-lint-ignore no-console -- TODO: consider improving logging
console.error(err);
}
}
}
Expand Down
1 change: 1 addition & 0 deletions tools/format-benchmark-results.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,6 @@ const paths = Array.from(Deno.readDirSync(resultsDir)).map((x) =>
for (const path of paths) {
const results = JSON.parse(await Deno.readTextFile(path));
const markdown = formatResultsAsMarkdown(results);
// deno-lint-ignore no-console
console.log(markdown);
}
Loading