-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump plug to version 1.0.1 #81
Conversation
The CI is failing with a weird error, try rebasing |
@DjDeveloperr The current CI error seems to be because of a flaky test? I get this error locally sometime on my windows machine too when running the tests, even without the changes in this PR. |
Huh the CI on main seems to pass every time (I tried multiple runs) but never passed on the PR 🤔 |
I'll look into this PR as soon as I find some time |
The problem is I can't reproduce this on my local Windows machine... |
I think I may have found the fix, try rebasing now |
Is the PR tested locally? The CI does not seem to test the plug actually downloading the binary. |
Worked on my windows computer a week ago and when tested on a mac without sudo it gave a |
Did the permission issue on macOS exist before, or is that something recent? |
It was probably an issue before too, and there is a resolved similar issue in the plug repo from a little while ago. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, okay. Otherwise, LGTM! Thanks
No description provided.