This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
adds sam.yaml for publishing to SAR #17
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| AWSTemplateFormatVersion: '2010-09-09' | ||
| Transform: AWS::Serverless-2016-10-31 | ||
| Description: > | ||
| deno-runtime | ||
|
|
||
| Example custom runtime for Deno | ||
|
|
||
| Resources: | ||
| DenoRuntime: | ||
| Type: AWS::Lambda::LayerVersion | ||
| Properties: | ||
| Content: | ||
| S3Bucket: begin-public-east-1 | ||
| S3Key: deno-runtime.zip | ||
|
There was a problem hiding this comment. Is this deno-lambda-layer.zip ? There was a problem hiding this comment. It may be the s3 thing is not required (and can use ContentUri): https://serverless.pub/sar-layers/ There was a problem hiding this comment.
yes
maybe! seems the docs are pretty thin and maybe in flux; typical aws! =P There was a problem hiding this comment. Didn't work without s3! AWS docs seem very thin :) |
||
|
|
||
| Outputs: | ||
| DenoRuntimeArn: | ||
| Value: !Ref DenoRuntime | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think this would make sense to be called simply "Deno" ? or is it important it's suffixed with Runtime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't really matter / just a clarity thing / end user probably won't see it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In serverless it's very fussy about being called DenoLambdaLayer.