ci: fix uploading canary (#25715)

If a newer version was available the script was exiting with code 1.
denoland · Sep 18, 2024 · 315baeb · 315baeb
1 parent 5057f58
commit 315baeb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/.github/workflows/ci.generate.ts b/.github/workflows/ci.generate.ts
@@ -818,6 +818,8 @@ const ci = {
             "if [ $? -eq 0 ]; then",
             "  echo ${{ github.sha }} > canary-latest.txt",
             '  gsutil -h "Cache-Control: no-cache" cp canary-latest.txt gs://dl.deno.land/canary-$(rustc -vV | sed -n "s|host: ||p")-latest.txt',
+            "else",
+            '  echo "Skipping upload, because newer canary version is already available"',
             "fi",
           ].join("\n"),
         },
@@ -1101,6 +1103,8 @@ const ci = {
             "if [ $? -eq 0]; then",
             "  echo ${{ github.sha }} > canary-latest.txt",
             '  gsutil -h "Cache-Control: no-cache" cp canary-latest.txt gs://dl.deno.land/canary-latest.txt',
+            "else",
+            '  echo "Skipping upload, because newer canary version is already available"',
             "fi",
           ].join("\n"),
         },

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -491,6 +491,8 @@ jobs:
           if [ $? -eq 0 ]; then
             echo ${{ github.sha }} > canary-latest.txt
             gsutil -h "Cache-Control: no-cache" cp canary-latest.txt gs://dl.deno.land/canary-$(rustc -vV | sed -n "s|host: ||p")-latest.txt
+          else
+            echo "Skipping upload, because newer canary version is already available"
           fi
       - name: Autobahn testsuite
         if: |-
@@ -699,4 +701,6 @@ jobs:
           if [ $? -eq 0]; then
             echo ${{ github.sha }} > canary-latest.txt
             gsutil -h "Cache-Control: no-cache" cp canary-latest.txt gs://dl.deno.land/canary-latest.txt
+          else
+            echo "Skipping upload, because newer canary version is already available"
           fi