Make lsan happy

.travis.yml

@@ -132,5 +132,5 @@ jobs:
       - third_party/depot_tools/gn gen target/debug
       - export ASAN_OPTIONS=detect_leaks=1
       - ./tools/build.py test_cc
-      - ./target/debug/test_cc
+      - ./target/debug/test_cc --expose-gc
 

core/libdeno/api.cc

@@ -71,6 +71,11 @@ Deno* deno_new(deno_config config) {
       deno::InitializeContext(isolate, context);
     }
     d->context_.Reset(isolate, context);
+
+    d->gc_observer_private_symbol_.Reset(
+        isolate,
+        v8::Private::New(isolate, v8::String::NewFromUtf8(
+                                      isolate, "deno:gc_observer:symbol")));
   }
 
   return reinterpret_cast<Deno*>(d);

core/libdeno/binding.cc

@@ -208,12 +208,17 @@ void SetGCObserver(const v8::FunctionCallbackInfo<v8::Value>& args) {
   v8::Isolate::Scope isolate_scope(isolate);
   v8::EscapableHandleScope handle_scope(isolate);
 
+  DenoIsolate* d = DenoIsolate::FromIsolate(isolate);
+  auto context = d->context_.Get(isolate);
   auto obj = args[0].As<v8::Object>();
   auto callback = args[1].As<v8::Function>();
 
   auto observer = new GCObserver();
   observer->Register(isolate, obj);
   observer->SetCallback(isolate, callback);
+  // Make LSAN happy
+  obj->SetPrivate(context, d->gc_observer_private_symbol_.Get(isolate),
+                  v8::External::New(isolate, observer));
 
   handle_scope.Escape(obj);
   args.GetReturnValue().Set(obj);

core/libdeno/internal.h

@@ -113,6 +113,7 @@ class DenoIsolate {
   deno_resolve_cb resolve_cb_;
 
   v8::Persistent<v8::Context> context_;
+  v8::Persistent<v8::Private> gc_observer_private_symbol_;
   std::map<size_t, v8::Persistent<v8::Value>> zero_copy_map_;
   std::map<int, v8::Persistent<v8::Value>> pending_promise_map_;
   std::string last_exception_;