Skip to content

Commit

Permalink
feat(ext/node): export missing symbols from domain, puncode, repl, tls (
Browse files Browse the repository at this point in the history
  • Loading branch information
bartlomieju authored Sep 12, 2024
1 parent 3f6605d commit 3a38375
Show file tree
Hide file tree
Showing 6 changed files with 96 additions and 2 deletions.
67 changes: 66 additions & 1 deletion ext/node/polyfills/async_hooks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,72 @@ export function executionAsyncResource() {
return {};
}

export const asyncWrapProviders = ObjectFreeze({ __proto__: null });
export const asyncWrapProviders = ObjectFreeze({
__proto__: null,
NONE: 0,
DIRHANDLE: 1,
DNSCHANNEL: 2,
ELDHISTOGRAM: 3,
FILEHANDLE: 4,
FILEHANDLECLOSEREQ: 5,
BLOBREADER: 6,
FSEVENTWRAP: 7,
FSREQCALLBACK: 8,
FSREQPROMISE: 9,
GETADDRINFOREQWRAP: 10,
GETNAMEINFOREQWRAP: 11,
HEAPSNAPSHOT: 12,
HTTP2SESSION: 13,
HTTP2STREAM: 14,
HTTP2PING: 15,
HTTP2SETTINGS: 16,
HTTPINCOMINGMESSAGE: 17,
HTTPCLIENTREQUEST: 18,
JSSTREAM: 19,
JSUDPWRAP: 20,
MESSAGEPORT: 21,
PIPECONNECTWRAP: 22,
PIPESERVERWRAP: 23,
PIPEWRAP: 24,
PROCESSWRAP: 25,
PROMISE: 26,
QUERYWRAP: 27,
QUIC_ENDPOINT: 28,
QUIC_LOGSTREAM: 29,
QUIC_PACKET: 30,
QUIC_SESSION: 31,
QUIC_STREAM: 32,
QUIC_UDP: 33,
SHUTDOWNWRAP: 34,
SIGNALWRAP: 35,
STATWATCHER: 36,
STREAMPIPE: 37,
TCPCONNECTWRAP: 38,
TCPSERVERWRAP: 39,
TCPWRAP: 40,
TTYWRAP: 41,
UDPSENDWRAP: 42,
UDPWRAP: 43,
SIGINTWATCHDOG: 44,
WORKER: 45,
WORKERHEAPSNAPSHOT: 46,
WRITEWRAP: 47,
ZLIB: 48,
CHECKPRIMEREQUEST: 49,
PBKDF2REQUEST: 50,
KEYPAIRGENREQUEST: 51,
KEYGENREQUEST: 52,
KEYEXPORTREQUEST: 53,
CIPHERREQUEST: 54,
DERIVEBITSREQUEST: 55,
HASHREQUEST: 56,
RANDOMBYTESREQUEST: 57,
RANDOMPRIMEREQUEST: 58,
SCRYPTREQUEST: 59,
SIGNREQUEST: 60,
TLSWRAP: 61,
VERIFYREQUEST: 62,
});

class AsyncHook {
enable() {
Expand Down
14 changes: 14 additions & 0 deletions ext/node/polyfills/domain.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,20 @@ function emitError(e) {
this.emit("error", e);
}

// TODO(bartlomieju): maybe use this one
// deno-lint-ignore prefer-const
let stack = [];
export const _stack = stack;
export const active = null;

export function create() {
return new Domain();
}

export function createDomain() {
return new Domain();
}

export class Domain extends EventEmitter {
#handler;

Expand Down Expand Up @@ -85,6 +96,9 @@ export class Domain extends EventEmitter {
}
}
export default {
_stack,
create,
active,
createDomain,
Domain,
};
1 change: 1 addition & 0 deletions ext/node/polyfills/internal/buffer.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -2606,6 +2606,7 @@ export default {
constants,
isAscii,
isUtf8,
INSPECT_MAX_BYTES,
kMaxLength,
kStringMaxLength,
SlowBuffer,
Expand Down
5 changes: 4 additions & 1 deletion ext/node/polyfills/punycode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import { deprecate } from "node:util";

import { ucs2 } from "ext:deno_node/internal/idna.ts";

const version = "2.1.0";

// deno-lint-ignore no-explicit-any
function punyDeprecated(fn: any) {
return deprecate(
Expand All @@ -37,12 +39,13 @@ function encode(domain) {
return punyDeprecated(op_node_idna_punycode_encode)(domain);
}

export { decode, encode, toASCII, toUnicode, ucs2 };
export { decode, encode, toASCII, toUnicode, ucs2, version };

export default {
decode,
encode,
toASCII,
toUnicode,
ucs2,
version,
};
7 changes: 7 additions & 0 deletions ext/node/polyfills/repl.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
// Copyright Joyent and Node contributors. All rights reserved. MIT license.

import { primordials } from "ext:core/mod.js";
import { notImplemented } from "ext:deno_node/_utils.ts";
const { Symbol } = primordials;

export const REPL_MODE_SLOPPY = Symbol("repl-sloppy");
export const REPL_MODE_STRICT = Symbol("repl-strict");

export class REPLServer {
constructor() {
Expand Down Expand Up @@ -61,4 +66,6 @@ export default {
builtinModules,
_builtinLibs,
start,
REPL_MODE_SLOPPY,
REPL_MODE_STRICT,
};
4 changes: 4 additions & 0 deletions ext/node/polyfills/tls.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ export const rootCertificates = undefined;
export const DEFAULT_ECDH_CURVE = "auto";
export const DEFAULT_MAX_VERSION = "TLSv1.3";
export const DEFAULT_MIN_VERSION = "TLSv1.2";
export const CLIENT_RENEG_LIMIT = 3;
export const CLIENT_RENEG_WINDOW = 600;

export class CryptoStream {}
export class SecurePair {}
Expand All @@ -58,6 +60,8 @@ export default {
DEFAULT_ECDH_CURVE,
DEFAULT_MAX_VERSION,
DEFAULT_MIN_VERSION,
CLIENT_RENEG_LIMIT,
CLIENT_RENEG_WINDOW,
};

export const checkServerIdentity = tlsWrap.checkServerIdentity;
Expand Down

0 comments on commit 3a38375

Please sign in to comment.