Skip to content

Commit

Permalink
fix(npm): better error handling for remote npm deps (#25670)
Browse files Browse the repository at this point in the history
  • Loading branch information
dsherret authored Sep 16, 2024
1 parent e81c67b commit 8fe90d2
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ deno_doc = { version = "0.148.0", features = ["html", "syntect"] }
deno_graph = { version = "=0.82.1" }
deno_lint = { version = "=0.65.0", features = ["docs"] }
deno_lockfile.workspace = true
deno_npm = "=0.25.0"
deno_npm = "=0.25.1"
deno_package_json.workspace = true
deno_runtime = { workspace = true, features = ["include_js_files_for_snapshotting"] }
deno_semver.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/npm/dynamic_npm_resolution_failure/main.out
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Download http://localhost:4260/@denotest/dep-cannot-parse
[UNORDERED_END]
Download http://localhost:4260/chalk/chalk-5.0.1.tgz
Hi
TypeError: Error in @denotest/dep-cannot-parse@1.0.0 parsing version requirement for dependency: @denotest/esm-basic@unknown-scheme:unknown
TypeError: Error in @denotest/dep-cannot-parse@1.0.0 parsing version requirement for dependency "@denotest/esm-basic": "unknown-scheme:unknown"
0: Invalid version requirement
1: Unexpected character.
unknown-scheme:unknown
Expand Down

0 comments on commit 8fe90d2

Please sign in to comment.