-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deno bundle
fails to resolve react/jsx-runtime
#13389
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
We need to inject this module into the bundle when present in the config. Even though it is in the module graph, because swc does the bundling, it isn't away of it directly. |
I also see this issue when doing |
Fixed by #15561. Still needs a test |
This commit adds some regression tests for using `jsxImportSource` in the config file in combination with an import map. These underlying issues were fixed by #15561. Closes #13389 Closes #14723 --------- Co-authored-by: Aapo Alasuutari <aapo.alasuutari@gmail.com> Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
same problem with Deno 2, no way to run next then? |
@voltuer Did you intend to comment on a different issue? The |
I'm seeing an issue with this when trying to do
deno bundle
withreact/jsx-runtime
, created repro here with description of error: https://github.com/pheuter/hello-deno#blocking-issue.Currently unable to bundle client-side code using
react/jsx-runtime
despitedeno run
working just fine using the same code and config:Oddly enough, the issue appears to go away when I explicitly do
/** @jsxImportSource https://esm.sh/react@17.0.2 */
in every tsx file, which I'm trying to avoid with this optimization in the first place.The text was updated successfully, but these errors were encountered: