Support npm:pm2 #16753

bartlomieju · 2022-11-22T01:01:45Z

    > @iugo how is it same error? What command are you trying to run?

run command deno run -A npm:pm2 --help.

same error, error info is x.y.z is not a function.

Originally posted by @iugo in #16679 (comment)

The text was updated successfully, but these errors were encountered:

khrj · 2022-11-22T07:20:03Z

Min. example

import chalk from "npm:chalk@3"
console.log(chalk.bold.green("Hello"))

Errors:

error: Uncaught TypeError: chalk.bold.green is not a function
console.log(chalk.bold.green("Hello"))
                       ^

khrj · 2022-11-22T07:38:14Z

The same issue is also present when using createRequire

khrj · 2022-11-22T10:49:04Z

I've dissected through the code for chalk v3 and have managed to get pure JS (no deps) code that works in node, but fails in Deno. I'm not completely sure yet but it seems like Node is handling object prototypes differently from Deno, I'll try to get a cleaner example and then post it here

khrj · 2022-11-22T10:50:38Z

Note that the code works in node and not in Deno even when not using npm specifiers / createRequire, so this isn't an issue with the npm compatibility layer (or std/node)

khrj · 2022-11-22T11:05:09Z

Duplicate of #13321

bartlomieju · 2022-11-22T13:02:16Z

If this is because of chalk@3 then it's because of missing "proto" that Deno doesn't support and will not in the future. So the best bet is to ask pm2 maintainers to update their dependencies.

khrj · 2022-11-22T15:37:48Z

Yes, it is because of that -- is there no chance of implementing __proto__ to internally call Object.setPrototypeOf? If not for Deno modules, at least for npm specifiers to not break existing modules.

I've run grep through the node_modules of the top 10 packages on npm and nearly all of them have .__proto__ somewhere.

iuioiua · 2022-12-06T19:35:59Z

FYI, @khrj is aiming to fix this in Unitech/pm2#5489

khrj · 2022-12-07T03:12:47Z

Note that even after proto is fixed, pm2 will still be broken by #16784

lino-levan · 2024-03-18T17:55:27Z

pm2 now works with unsafe proto!

bartlomieju · 2024-03-21T04:24:13Z

This still doesn't work for me. It appears that we're not correctly handling "ipc" option in child_process module in new ChildProcess():

Spawning PM2 daemon with pm2_home=/Users/ib/.pm2
spawning
caught error Error: Not implemented: toDenoStdio pipe=string (ipc)
    at notImplemented (ext:deno_node/_utils.ts:27:9)
    at toDenoStdio (ext:deno_node/internal/child_process.ts:379:5)
    at new ChildProcess (ext:deno_node/internal/child_process.ts:197:16)
    at Object.spawn (node:child_process:192:10)
    at module.exports.Client.launchDaemon (file:///Users/ib/Library/Caches/deno/npm/registry.npmjs.org/pm2/5.3.1/lib/Client.js:256:40)
    at file:///Users/ib/Library/Caches/deno/npm/registry.npmjs.org/pm2/5.3.1/lib/Client.js:104:10
    at file:///Users/ib/Library/Caches/deno/npm/registry.npmjs.org/pm2/5.3.1/lib/Client.js:321:14
    at Array.processTicksAndRejections (ext:deno_node/_next_tick.ts:37:11)
    at eventLoopTick (ext:core/01_core.js:166:29)
error: Uncaught TypeError: Cannot read properties of undefined (reading 'unref')
    at ChildProcess.unref (ext:deno_node/internal/child_process.ts:323:19)
    at module.exports.Client.launchDaemon (file:///Users/ib/Library/Caches/deno/npm/registry.npmjs.org/pm2/5.3.1/lib/Client.js:274:9)
    at file:///Users/ib/Library/Caches/deno/npm/registry.npmjs.org/pm2/5.3.1/lib/Client.js:104:10
    at file:///Users/ib/Library/Caches/deno/npm/registry.npmjs.org/pm2/5.3.1/lib/Client.js:321:14
    at Array.processTicksAndRejections (ext:deno_node/_next_tick.ts:37:11)
    at eventLoopTick (ext:core/01_core.js:166:29)

CC @littledivy is it something you could look at? Since we already support IPC in subprocesses it feels like there's something misconfigured that makes it crash.

littledivy · 2024-03-22T04:01:49Z

@bartlomieju I'm not getting the IPC error. It fails on .unref

$ deno run -A --unstable-unsafe-proto npm:pm2 --help
[PM2] Spawning PM2 daemon with pm2_home=/home/divy/.pm2
error: Uncaught TypeError: Cannot read properties of undefined (reading 'unref')
    at ChildProcess.unref (ext:deno_node/internal/child_process.ts:221:19)
    at module.exports.Client.launchDaemon (file:///home/divy/.cache/deno/npm/registry.npmjs.org/pm2/5.3.1/lib/Client.js:274:9)
    at file:///home/divy/.cache/deno/npm/registry.npmjs.org/pm2/5.3.1/lib/Client.js:104:10
    at file:///home/divy/.cache/deno/npm/registry.npmjs.org/pm2/5.3.1/lib/Client.js:321:14
    at Array.processTicksAndRejections (ext:deno_node/_next_tick.ts:25:11)
    at eventLoopTick (ext:core/01_core.js:166:29)

bartlomieju · 2024-03-22T04:10:42Z

@littledivy - correct. I added additional logs to surface that error (the catch handler for when the process is spawned).

littledivy · 2024-03-22T04:26:04Z

Ah, I see the problem now. Our implementation only supports non-stdio IPC.

We need to implement support for stdio as raw fds and "ipc" in Deno.Command.

const process = new Deno.Command(command, {
  stdout: "ipc",
  // or stdout: 3
}).spawn();

bartlomieju · 2024-03-22T04:31:59Z

Huh, i thought we already had it. Is it any different than the current IPC support we have?

littledivy · 2024-05-27T05:02:18Z

This should be straightforward to implement:

Add "ipc" (or maybe "ipc_for_internal_use") in Deno.Command's stdin, stdout, stderr. Set the args.ipc FD and the ipc code path should automatically setup the channels.
Allow numeric rids in Deno.Command's stdio options that deserialize to StdioOrRid in runtime/ops/process.rs, there is already code to map file rids to stdio in there from Deno.run.
Finally, allow "ipc" and numeric values in the toDenoStdio conversion in ext/node/child_process.ts

…4106) Add supports for "ipc" and fd options in child_process spawn API. Internal changes: Adds a hidden rid and "ipc_for_internal_use" option to Deno.Command. Used by `node:child_process` Example: ```js const out = fs.openSync("./logfile.txt", 'a') const proc = spawn(process.execPath, ["./main.mjs", "child"], { stdio: ["ipc", out, "inherit"] }); ``` Ref #16753

littledivy · 2024-07-04T11:30:11Z

stdio IPC support landed. A few more things to solve before this works:

By default, pm2 spawns its daemon using node (hard-coded). The
daemon fails to start in non-BYONM context because Node doesn't
understand Deno npm resolution.

In BYONM context the daemon spawns but IPC between Deno and Node
doesn't work because of implementation differences currently.

We have 2 options:

Override node <daemon> to deno run <daemon> in child_process#spawn
Try to connect with Node IPC

birkskyum · 2024-08-11T22:36:07Z

It would in general be great to have a way to override nested uses of node with deno, even by default, similar to the '--bun' flag used in that runtime (which will also be default eventually)

bartlomieju added needs investigation requires further investigation before determining if it is an issue or not node compat labels Nov 22, 2022

khrj mentioned this issue Nov 22, 2022

--inspect-brk doesn't stop execution when running global npm commands #16757

Closed

khrj mentioned this issue Nov 23, 2022

fix(runtime): implement __proto__ getter, ignore and warn on setter #16775

Open

bartlomieju added the node API polyfill Related to various "node:*" modules APIs label Mar 4, 2024

bartlomieju assigned crowlKats Mar 12, 2024

bartlomieju assigned littledivy and unassigned crowlKats Mar 21, 2024

bartlomieju mentioned this issue Mar 21, 2024

Support NX (running npm:nx) #22966

Closed

littledivy mentioned this issue Jun 5, 2024

fix(ext/node): support stdin child_process IPC & fd stdout/stderr #24106

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support npm:pm2 #16753

Support npm:pm2 #16753

bartlomieju commented Nov 22, 2022

khrj commented Nov 22, 2022

khrj commented Nov 22, 2022

khrj commented Nov 22, 2022 •

edited

Loading

khrj commented Nov 22, 2022

khrj commented Nov 22, 2022

bartlomieju commented Nov 22, 2022

khrj commented Nov 22, 2022 •

edited

Loading

iuioiua commented Dec 6, 2022

khrj commented Dec 7, 2022

lino-levan commented Mar 18, 2024

bartlomieju commented Mar 21, 2024

littledivy commented Mar 22, 2024

bartlomieju commented Mar 22, 2024

littledivy commented Mar 22, 2024 •

edited

Loading

bartlomieju commented Mar 22, 2024

littledivy commented May 27, 2024

littledivy commented Jul 4, 2024 •

edited

Loading

birkskyum commented Aug 11, 2024

Support npm:pm2 #16753

Support npm:pm2 #16753

Comments

bartlomieju commented Nov 22, 2022

khrj commented Nov 22, 2022

khrj commented Nov 22, 2022

khrj commented Nov 22, 2022 • edited Loading

khrj commented Nov 22, 2022

khrj commented Nov 22, 2022

bartlomieju commented Nov 22, 2022

khrj commented Nov 22, 2022 • edited Loading

iuioiua commented Dec 6, 2022

khrj commented Dec 7, 2022

lino-levan commented Mar 18, 2024

bartlomieju commented Mar 21, 2024

littledivy commented Mar 22, 2024

bartlomieju commented Mar 22, 2024

littledivy commented Mar 22, 2024 • edited Loading

bartlomieju commented Mar 22, 2024

littledivy commented May 27, 2024

littledivy commented Jul 4, 2024 • edited Loading

birkskyum commented Aug 11, 2024

khrj commented Nov 22, 2022 •

edited

Loading

khrj commented Nov 22, 2022 •

edited

Loading

littledivy commented Mar 22, 2024 •

edited

Loading

littledivy commented Jul 4, 2024 •

edited

Loading