Supporting vitest tracking issue

[marvinhagemeister]

This is an issue to track the progress on getting the vitest test runner to work. I'm currently using the test suite from urql to check our progress.

• Web MessagePort not converted to worker_thread MessagePort Bug: port.addListener is not a function #23828
• Node globals missing in vm.runInThisConext Bug: Node vm doesn't have Node's global global #23852
• TTY test result reporter not working because of this check https://github.com/vitest-dev/vitest/blob/main/packages/vitest/src/utils/env.ts#L1
  • signal-exit is used under the hood. It's likely that this issue causes CTRL+C to not work: Listeners for SIGINT (and other) signals are not registered in EventEmitter #22892
• Test run doesn't seem to complete

[birkskyum]

With the standard example it appear to still (deno 1.44.4+bc8a0e6) hang at:

➜ deno task test              
Task test vitest

 DEV  v1.6.0 

Both w/o DENO_FUTURE=1

[birkskyum]

After this PR ( #24763 ) I tried this again with deno 1.45.5, and these scenarios does indeed appear to work now:

• using "--pool=forks" with Vitest 1.x w/ DENO_FUTURE=1
• using Vitest 2.x w/ DENO_FUTURE=1

Scenarios that doesn't work out-of-the-box, but which will resolve over time / has workarounds:

• using Deno 1.x without the DENO_FUTURE=1 flag
• using vitest 1.x without the --pool=forks flag

[birkskyum]

Alright, so I'm on Vitest 2 (it defaults to pool: forks) and Deno 2 (deno 2.0.0-rc.1+7bfcb4d) now.

deno.json

{
  "nodeModulesDir": "auto",
  "tasks": {
    "test": "vitest"
  },
  "imports": { "jsdom": "npm:jsdom@^25.0.0", "vitest": "npm:vitest@^2.0.5" }
}

sum.test.ts

import { expect, test } from "vitest";

export function sum(a, b) {
  return a + b
}

test('adds 1 + 2 to equal 3', () => {
  expect(sum(1, 2)).toBe(3)
})

vitest.config.ts

import {defineConfig} from "vitest/config";

export default defineConfig({
  test: {
    environment: 'jsdom'
  }
})

Run

• deno install
• deno task test

Error:

 DEV  v2.0.5 /Users/admin/repos/deno-kitchensink/vitest-demo


⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Unhandled Errors ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

Vitest caught 1 unhandled error during the test run.
This might cause false positive tests. Resolve unhandled errors to make sure your tests are not affected.

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Unhandled Error ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
TypeError: Cannot redefine property: location
 ❯ populateGlobal node_modules/.deno/vitest@2.0.5/node_modules/vitest/dist/chunks/index.lVXYBqEP.js:374:12
 ❯ Object.setup node_modules/.deno/vitest@2.0.5/node_modules/vitest/dist/chunks/index.lVXYBqEP.js:526:33
 ❯ withEnv node_modules/.deno/vitest@2.0.5/node_modules/vitest/dist/chunks/runBaseTests.CyvqmuC9.js:92:15
 ❯ run node_modules/.deno/vitest@2.0.5/node_modules/vitest/dist/chunks/runBaseTests.CyvqmuC9.js:116:3
 ❯ runBaseTests node_modules/.deno/vitest@2.0.5/node_modules/vitest/dist/chunks/base.CC5R_kgU.js:31:3
 ❯ ForksBaseWorker.executeTests node_modules/.deno/vitest@2.0.5/node_modules/vitest/dist/workers/forks.js:25:7
 ❯ execute node_modules/.deno/vitest@2.0.5/node_modules/vitest/dist/worker.js:115:5
 ❯ onMessage node_modules/.deno/tinypool@1.0.1/node_modules/tinypool/dist/entry/process.js:55:20

⎯⎯⎯⎯⎯⎯⎯⎯

If I remove environment: "jsdom" it works:

 DEV  v2.0.5 /Users/admin/repos/deno-kitchensink/vitest-demo

 ✓ sum.test.ts (1)
   ✓ adds 1 + 2 to equal 3

 Test Files  1 passed (1)
      Tests  1 passed (1)
   Start at  23:47:08
   Duration  170ms (transform 15ms, setup 0ms, collect 15ms, tests 1ms, environment 0ms, prepare 46ms)