Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: deno add doesn't support --allow-scripts argument #25533

Closed
marvinhagemeister opened this issue Sep 9, 2024 · 0 comments · Fixed by #26075
Closed

Bug: deno add doesn't support --allow-scripts argument #25533

marvinhagemeister opened this issue Sep 9, 2024 · 0 comments · Fixed by #26075
Assignees
@nathanwhit
Labels
bug Something isn't working correctly install permissions related to --allow-* flags

Comments

@marvinhagemeister
Copy link
Contributor

marvinhagemeister commented Sep 9, 2024 •
edited
Loading

Screenshot 2024-09-09 at 16 07 28

Steps to reproduce

  1. Run deno add --allow-scripts npm:@swc-node/core

Version: Deno 2.0.0-rc.1+ce1d668
@marvinhagemeister marvinhagemeister added bug Something isn't working correctly permissions related to --allow-* flags install labels Sep 9, 2024
@nathanwhit nathanwhit self-assigned this Sep 9, 2024
@nathanwhit nathanwhit mentioned this issue Oct 9, 2024
Merged
nathanwhit added a commit that referenced this issue Oct 12, 2024
@nathanwhit
feat(npm): support --allow-scripts on deno run (and deno add, `…
7a990d9 
…deno test`, etc) (#26075)

Fixes #25533. Fixes
#25396.

Previously we only supported it on `deno install` and `deno cache`,
which is annoying if you're using `nodeModulesDir: auto`.

Also changes from printing output of lifecycle scripts directly to
capturing the output and only printing it on error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanwhit nathanwhit

Labels
bug Something isn't working correctly install permissions related to --allow-* flags
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(npm): support --allow-scripts on deno run (and deno add, deno test, etc) denoland/deno
2 participants
@marvinhagemeister @nathanwhit