-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deno install
issue with github package uWebSockets.js
#25648
Comments
I tried extensively, and yep, that's not possible. |
Also, porting uWS has already been dismissed : #3366 (comment) |
You can install your dependencies with |
deno install
issue with crossws / uWebSockets.js
@lucacasonato uWebSocket doesn't want to be on any package manager |
|
deno install
issue with crossws / uWebSockets.jsdeno install
issue with github package uWebSockets.js
This package defines an optional peer dependency on |
Opened a PR in |
Partially addresses #25648. This allows packages that use `crossws` to be installed with `deno install`. `crossws` specifies an optional peer dependency on `uWebSockets`, but `uWebSockets` is not on npm (it is used with `git:` or `github:` specifiers). Previously we would error on this, now we don't error on non-existent optional peer dependencies.
This doesn't break anymore - awesome! |
So how do i get uWebsocket insalled on deno 2.0.0-rc.8 - If at all possible Running deno install
error: Error in hyper-express@6.17.2 parsing version requirement for dependency "uWebSockets.js": "github:uNetworking/uWebSockets.js#v20.48.0"
Caused by:
Package specified a dependency outside of npm (github:uNetworking/uWebSockets.js#v20.48.0). Deno does not install these for security reasons. The npm package should be improved to have all its dependencies on npm.
To work around this, you can use a package.json and install the dependencies via `npm install`. But using npm install will install the build for nodeJs.
|
@BolverBlitz I have opened a new issue for that: #25956 |
Version: deno 2.0.0-rc.2
https://github.com/unjs/crossws
Some projects use crossws, which use uWebSocksts, can't install, because uWebSockets.js isn't on npm, it's in here https://github.com/uNetworking/uWebSockets.js/
Affects anything that build on top of crossws, which is also everything build on vinxi:
Simple repro
Clone https://github.com/tanstack/tanstack.com deno install (with deno 2.0 rc.2) error: npm package 'uWebSockets.js' does not exist.
The text was updated successfully, but these errors were encountered: