Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master is red #2787

Closed
ry opened this issue Aug 16, 2019 · 0 comments
Closed

master is red #2787

ry opened this issue Aug 16, 2019 · 0 comments

Comments

@ry
Copy link
Member

ry commented Aug 16, 2019 •
edited
Loading

Discovered by @kt3k here #2782 (comment)

$ ./target/debug/deno bundle https://deno.land/std/http/file_server.ts
Bundling "file_server.bundle.js"
Emitting bundle to "file_server.bundle.js"
517.7 kB emitted.
$ ./target/release/deno bundle https://deno.land/std/http/file_server.ts
Bundling "file_server.bundle.js"
Emitting bundle to "file_server.bundle.js"
Segmentation fault: 11

This needs to be fixed before any new commits can land.

Likely caused by 498f6ad
ry added a commit to ry/deno that referenced this issue Aug 16, 2019
@ry
Revert "Remove dead code: legacy read/write ops (denoland#2776)"
7de270e 
Seem to have caused master to go red. Cause unknown currently unknown,
see denoland#2787.

This reverts commit 498f6ad.
@ry ry mentioned this issue Aug 16, 2019
Merged
ry added a commit to ry/deno that referenced this issue Aug 16, 2019
@ry
Revert "Remove dead code: legacy read/write ops"
5068221 
This is causing a segfault for unknown reasons - see denoland#2787.

This reverts commit 498f6ad.
ry added a commit that referenced this issue Aug 16, 2019
@ry
Revert "Remove dead code: legacy read/write ops"
81f809f 
This is causing a segfault for unknown reasons - see #2787.

This reverts commit 498f6ad.
@ry ry closed this as completed Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ry