Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to latest typescript #417

Closed
ry opened this issue Jul 26, 2018 · 4 comments
Closed

upgrade to latest typescript #417

ry opened this issue Jul 26, 2018 · 4 comments

Comments

@ry
Copy link
Member

ry commented Jul 26, 2018

  1. edit version here: https://github.com/ry/deno/blob/6b49944da1e7b06aeba04b1c0ded8e3fdb3c436b/package.json#L21
  2. run ./tools/sync_third_party.py
  3. commit changes in third_party repo. send a pull request to https://github.com/ry/deno_third_party (only add relevant files - there may be others that were mistakenly not committed yet)
  4. fix any errors: ./tools/test.py out/debug
  5. run tools/format.py
  6. send me a PR.

This is probably harder than just upgrading. Potentially difficult but good intro to runtime.ts.

@ry ry added this to the v0.1 (first binary release) milestone Jul 26, 2018
@kitsonk
Copy link
Contributor

kitsonk commented Jul 26, 2018

From the experience with Deno 1, there is this issue: microsoft/TypeScript#24638 which is only resolved in TypeScript 3.0 (which is in RC at the moment and should be released any moment).

@kitsonk
Copy link
Contributor

kitsonk commented Jul 29, 2018

Been looking at 3.0.0-rc in advance of its initial release. There was a restructuring of the built in libs, and lib.d.ts now "drags in" scripthost, webworker and dom libs. I tried to use --noLib which might actually be better for deno longer term, but the problem with that at is runtime.ts is only using single module compiling which means additional files (like lib.esnext.d.ts) can be specified.

@kitsonk
Copy link
Contributor

kitsonk commented Jul 29, 2018

Updated the WIP PR. Found it was easier to introduce lib.deno.d.ts and have the language service that is created at runtime use it as the default library. Now the runtime typings should better align to what is actually available and lib.deno.d.ts becomes the place where the global runtime environment for deno is described and applied to executed code.

@ry
Copy link
Member Author

ry commented Aug 2, 2018

Fixed in 36fa1ce

@ry ry closed this as completed Aug 2, 2018
piscisaureus pushed a commit to piscisaureus/deno that referenced this issue Oct 7, 2019
hardfist pushed a commit to hardfist/deno that referenced this issue Aug 7, 2024
With the upcoming v8 upgrade, we cannot support fastcalls for typed
buffers.

Fix for denoland#417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants