Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unit tests and improve code resiliency for runtime.ts #509

Closed
kitsonk opened this issue Aug 12, 2018 · 2 comments
Closed

Create unit tests and improve code resiliency for runtime.ts #509

kitsonk opened this issue Aug 12, 2018 · 2 comments
Milestone

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Aug 12, 2018

There are likely improvements to the logic, in particular, TypeScript invokes host.resolveModuleNames() several times to build a dependency graph, but currently runtime.ts will attempt to fetch the code each time from the privileged side of deno.

We also need unit tests to be able to better properly test the boundaries of the code and ensure it behaves as designed.

@swist
Copy link

swist commented Aug 13, 2018

This sounds pretty interesting. Are there any limitations/parameters to how you want this done?

@kitsonk
Copy link
Contributor Author

kitsonk commented Aug 14, 2018

@swist the only thing to mention is I do have my head around the problem and was likely going to try to tackle it over the next couple of days, though exactly how to expose and rationalise the API in runtime to be more testable was going to be sort of iterative. @ry wanted to put the unit tests in js/unit_tests.ts.

This was referenced Aug 14, 2018
@ry ry added this to the v0.2 milestone Aug 19, 2018
@ry ry closed this as completed in #564 Aug 22, 2018
hardfist pushed a commit to hardfist/deno that referenced this issue Aug 7, 2024
…and#509)

Calling `v8::ExternalReferences::new` does not take ownership of the Vec
- it internally copies the values into a new Vec. As a result, the
memory owned by the original Vec was never getting freed.

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants