deno fmt should format Markdown including code blocks

[David-Else]

At the moment Deno only formats JS and TS, but dprint can also format markdown including JS and TS code blocks:

#6682 (comment)

This would be an awesome feature for documentation, is it possible to enable it? Then we can get rid of Prettier.

[bartlomieju]

I think @dsherret is working on it

[bartlomieju]

dprint has dprint-plugin-markdown which we could use for this purpose. I wonder if dprint-plugin-typescript could take an option to format markdown code blocks (which would make dprint-plugin-markdown its dependency?). @dsherret thoughts?

[dsherret]

@bartlomieju why would it be that way instead of the other way around?

Though kind of not documented well, dprint-plugin-markdown has API for formatting code in markdown code blocks (see the third parameter): https://docs.rs/dprint-plugin-markdown/0.4.1/dprint_plugin_markdown/fn.format_text.html

I need to make dprint-plugin-markdown MIT, which I will do soon.

[bartlomieju]

@dsherret thanks for pointing that out, indeed the other way around seems like a better option.

I need to make dprint-plugin-markdown MIT, which I will do soon.

No rush :)

[dsherret]

@bartlomieju it's now MIT in 0.4.2.

By the way, regarding that format_text function's provided function, the first parameter is the code block tag, second param is file text, third is the current line width based on how much it's indented in the current markdown document.

[David-Else]

I see a1a806a just landed in master :)

Can we use deno fmt myfile1.md and it also formats js/ts code blocks in the file?

[bartlomieju]

I see a1a806a just landed in master :)

Can we use deno fmt myfile1.md and it also formats js/ts code blocks in the file?

@David-Else no, above commit changed only internal tooling used in repo, still need to implement it for deno fmt

[David-Else]

@bartlomieju I think you can remove the upstream label now?

[bartlomieju]

@bartlomieju I think you can remove the upstream label now?

@David-Else sure I removed it and added appropriate labels, I've also renamed the issue

[David-Else]

@bartlomieju Thanks.

The title is wrong for what I was requesting. Deno needs to format Markdown, that is .md files. That needs to include formatting code blocks inside that markdown.

There is no 'Markdown in code blocks'. The code blocks are in the Markdown. A better title would be deno fmt should format Markdown including code blocks. You might want to specify what types of code blocks are covered, JS and TS I assume.

[satyarohith]

I'll take a stab at it.