-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve Deno Language Server #187
Comments
Regarding point 2, I don't think Deno formats your code unless you tell it to?!
If you tied the formatter to |
@David-Else That is not the case, the deno formatter will run even without that configuration. It will run in JS files even if you have "[javascript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
}, |
@kyeotic Well, that is not good! I thought that bug had gone. I just want to make sure that we can always run the formatter without the language server running with |
This is now stale, closing. |
The current Deno Language Server seems to work very well, but it has many improvements
1. Deno Language Server always starts running even
deno.enable = false
vscode_deno/client/src/extension.ts
Lines 635 to 641 in 0fa031d
even if it is not a Deno project, the
Deno Language Server
is started.When deno.enable is changed, the LSP should be
enabled/disabled
2. deno formatting is always enabled even
deno.enable = false
ref: #101
3.
Deno Language Server
is a singleton even multiple workspaces have been openedThis will cause many problems, such as different workspaces and different environment variables. I think multiple LSP instances can solve these problems.
One LSP instance serves only one workspace.
This greatly simplifies the code and mental burden.
We don’t worry about what happens when an instance serves multiple workspaces
example: https://github.com/microsoft/vscode-extension-samples/tree/master/lsp-multi-server-sample
NOTE: Multiple instances will increase memory consumption, Average 50-70M per instance
The text was updated successfully, but these errors were encountered: