Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot remap a transitive dependency to a local file #7723

Closed
vovacodes opened this issue Sep 27, 2020 · 1 comment · Fixed by #8262
Closed

Cannot remap a transitive dependency to a local file #7723

vovacodes opened this issue Sep 27, 2020 · 1 comment · Fixed by #8262
Assignees
@kitsonk
Labels
cli related to cli/ dir feat new feature (which has been agreed to/accepted)

Comments

@vovacodes
Copy link

#5050 introduced the logic that prohibits static imports of local modules from remote modules. While I understand the security issues it solves, I believe, it also makes impossible some nice and valid use-cases, in particular, remapping a transitive dependency to a local module using an import map.
Can we somehow allow this use-case?
@vovacodes vovacodes mentioned this issue Sep 27, 2020
Merged
@kitsonk kitsonk added cli related to cli/ dir feat new feature (which has been agreed to/accepted) labels Sep 27, 2020
@kitsonk
Copy link
Contributor

kitsonk commented Sep 27, 2020

This is a legitimate use case we should support. We should address it during #7225.

@kitsonk kitsonk self-assigned this Nov 3, 2020
@kitsonk kitsonk mentioned this issue Nov 6, 2020
Merged
kitsonk added a commit that referenced this issue Nov 7, 2020
@kitsonk
fix(cli): allow remapping to locals for import map (#8262)
88c4d31 
Fixes #7723
jannes pushed a commit to jannes/deno that referenced this issue Dec 1, 2020
@kitsonk @jannes
fix(cli): allow remapping to locals for import map (denoland#8262)
c2eede2 
Fixes denoland#7723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kitsonk kitsonk

Labels
cli related to cli/ dir feat new feature (which has been agreed to/accepted)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): allow remapping to locals for import map kitsonk/deno
2 participants
@kitsonk @vovacodes