Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): support formatting json and markdown files #10180

Merged
merged 6 commits into from
May 18, 2021
Merged

feat(lsp): support formatting json and markdown files #10180

merged 6 commits into from
May 18, 2021

Conversation

satyarohith
Copy link
Member

@satyarohith satyarohith commented Apr 14, 2021 •
edited
Loading

Closes #9447
Closes #9415

@satyarohith satyarohith force-pushed the lsp/format_json_md branch 3 times, most recently from 9eed497 to b36cc0c Compare April 14, 2021 15:13
@satyarohith satyarohith marked this pull request as ready for review April 14, 2021 15:16
satyarohith
satyarohith commented Apr 14, 2021
View reviewed changes
@satyarohith satyarohith marked this pull request as draft April 14, 2021 16:11
@satyarohith satyarohith marked this pull request as ready for review April 15, 2021 08:00
disrupted added a commit to disrupted/dotfiles that referenced this pull request Apr 16, 2021
@disrupted
Try out formatting using deno for speed
3a5c096 
deno fmt is so much faster than prettier or even prettier_d

note to self: try out denols once denoland/deno#10180
is merged
@bartlomieju bartlomieju added this to the 1.10.0 milestone Apr 16, 2021
@bartlomieju bartlomieju requested a review from kitsonk April 21, 2021 14:34
@bartlomieju
Copy link
Member

@satyarohith please rebase

@satyarohith satyarohith force-pushed the lsp/format_json_md branch 2 times, most recently from 0911ea4 to 59b41bd Compare April 22, 2021 02:29
bartlomieju
bartlomieju reviewed Apr 26, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll wait for @kitsonk's review

@kitsonk
Copy link
Contributor

kitsonk commented Apr 26, 2021

Yeah, I will get to it tomorrow, sorry for the delay.

kitsonk
kitsonk reviewed Apr 28, 2021
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this require a complimentary PR in vscode_deno, so that it knows that we can handle the other file types?

@satyarohith satyarohith mentioned this pull request Apr 28, 2021
Merged
@satyarohith
Copy link
Member Author

Won't this require a complimentary PR in vscode_deno, so that it knows that we can handle the other file types?

I was waiting for this PR to get merged. I opened the PR anyway: denoland/vscode_deno#404

@satyarohith satyarohith requested a review from kitsonk April 28, 2021 18:37
kitsonk
kitsonk reviewed Apr 29, 2021
View reviewed changes
@satyarohith satyarohith force-pushed the lsp/format_json_md branch from 80ee6e8 to 714eeca Compare May 9, 2021 16:23
@kitsonk
Copy link
Contributor

kitsonk commented May 9, 2021

Looks like somehow a deadlock was introduced which is causing the integration tests sometimes to fail and the benchmark tests to fail. I will try to look at it later.

@kitsonk
Copy link
Contributor

kitsonk commented May 11, 2021

The deadlock was occurring on my local machine. I merged in #10555 and it fixed the deadlock.

@satyarohith satyarohith force-pushed the lsp/format_json_md branch from ad48d7d to 75388fc Compare May 16, 2021 21:09
@satyarohith satyarohith requested a review from kitsonk May 17, 2021 04:37
@kitsonk
Copy link
Contributor

kitsonk commented May 18, 2021

Sorry this keeps getting delayed... Now that we refactored the lsp tests (which is good for everyone) this needs a merge/rebase with upstream and the tests moved to cli/tests/integration_tests_lsp.rs.

@satyarohith satyarohith force-pushed the lsp/format_json_md branch from 75388fc to 8ec8e6d Compare May 18, 2021 02:24
kitsonk
kitsonk approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit d69a5fb into denoland:main May 18, 2021
@satyarohith satyarohith deleted the lsp/format_json_md branch May 18, 2021 07:06
piscisaureus pushed a commit that referenced this pull request May 31, 2021
@satyarohith @piscisaureus
feat(lsp): support formatting json and markdown files (#10180)
465036b 
Resolves #9447
Resolves #9415
piscisaureus pushed a commit that referenced this pull request May 31, 2021
@satyarohith @piscisaureus
feat(lsp): support formatting json and markdown files (#10180)
136ac4a 
Resolves #9447
Resolves #9415
piscisaureus pushed a commit that referenced this pull request May 31, 2021
@satyarohith @piscisaureus
feat(lsp): support formatting json and markdown files (#10180)
d52ea3b 
Resolves #9447
Resolves #9415
piscisaureus pushed a commit that referenced this pull request May 31, 2021
@satyarohith @piscisaureus
feat(lsp): support formatting json and markdown files (#10180)
6966c4e 
Resolves #9447
Resolves #9415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@kitsonk kitsonk kitsonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

lsp should support formatting json files lsp should support formatting md files
3 participants
@satyarohith @bartlomieju @kitsonk