Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op_crates/fetch): check fetch() argument length #10474

Merged
merged 3 commits into from May 3, 2021
Merged

fix(op_crates/fetch): check fetch() argument length #10474

merged 3 commits into from May 3, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 2, 2021

Related to #10203

Checks that fetch receives at least one arguement.

Relevant WebIDL:

partial interface mixin WindowOrWorkerGlobalScope {
  [NewObject] Promise<Response> fetch(RequestInfo input, optional RequestInit init = {});
};

- https://fetch.spec.whatwg.org/#fetch-method

input must be present.

cc @lucacasonato

@ghost ghost marked this pull request as ready for review May 2, 2021 22:22
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Must have missed this during fetch rewrite.

@ghost
Copy link
Author

ghost commented May 2, 2021

@lucacasonato Somewhat related, but I had barely left two comments on the rewrite PR, since I had barely checked it out within the hour. I'm not sure if those would be problematic or not, but it might be worth checking them out.

Test now passes
@lucacasonato lucacasonato merged commit 688557e into denoland:main May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant