Support CheckJS #1068
Merged
Support CheckJS #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
approved these changes
Oct 23, 2018
|
This was red in master - I had to revert #1070 |
ry
added a commit
to ry/deno
that referenced
this pull request
Oct 27, 2018
- Add URLSearchParams (denoland#1049) - Implement clone for FetchResponse (denoland#1054) - Use content-type headers when importing from URLs. (denoland#1020) - Use checkJs option, JavaScript will be type checked and users can supply JSDoc type annotations that will be enforced by Deno (denoland#1068) - Add separate http/https cache dirs to DENO_DIR (denoland#971) - Support https in fetch. (denoland#1100) - Add chmod/chmodSync on unix (denoland#1088) - Remove broken features: --deps and trace() (denoland#1103) - Ergonomics: Prompt TTY for permission escalation (denoland#1081)
Merged
ry
added a commit
that referenced
this pull request
Oct 27, 2018
- Add URLSearchParams (#1049) - Implement clone for FetchResponse (#1054) - Use content-type headers when importing from URLs. (#1020) - Use checkJs option, JavaScript will be type checked and users can supply JSDoc type annotations that will be enforced by Deno (#1068) - Add separate http/https cache dirs to DENO_DIR (#971) - Support https in fetch. (#1100) - Add chmod/chmodSync on unix (#1088) - Remove broken features: --deps and trace() (#1103) - Ergonomics: Prompt TTY for permission escalation (#1081)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #976
This PR enables the
--checkJsTypeScript compiler option. This means that JavaScript will be type checked and users can supply JSDoc type annotations that will be enforced by Deno, reporting type issues when running programmes. This means all JavaScript will be compared to the built in type library and ensure the JavaScript programmes utilise Deno APIs with type safety. The way JavaScript is checked by the TypeScript compiler is very loose, but allows users to incrementally "opt-in" using the JSDoc annotations.The feature is described here.
While the pragma of
// @ts-ignoreand// @ts-nocheckwork in Deno, it is not recommended they be used as they are simply ignoring a problem that might not yet be a runtime exception, but could/should be. My recommendation is that if there is any JavaScript that should work but fails because of a type error, we look at addressing why that is the case versus just ignoring it.