Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support CheckJS" #1070

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Revert "Support CheckJS" #1070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion js/compiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ export class DenoCompiler
// arguments
private readonly _options: Readonly<ts.CompilerOptions> = {
allowJs: true,
checkJs: true,
module: ts.ModuleKind.AMD,
outDir: "$deno$",
// TODO https://github.com/denoland/deno/issues/23
Expand Down
6 changes: 0 additions & 6 deletions tests/error_008_checkjs.js
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions tests/error_008_checkjs.js.out
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
{
"compilerOptions": {
"allowJs": true,
"allowUnreachableCode": false,
"baseUrl": ".",
"checkJs": true,
"module": "esnext",
"moduleResolution": "node",
"noImplicitReturns": true,
Expand Down
4 changes: 0 additions & 4 deletions website/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,12 +154,10 @@ function gen2(
};
}

// @ts-ignore
c3.generate({
bindto: id,
size: {
height: 300,
// @ts-ignore
width: window.chartWidth || 375 // TODO: do not use global variable
},
data: {
Expand Down Expand Up @@ -203,7 +201,6 @@ export async function drawChartsFromBenchmarkData(dataUrl) {
const sha1ShortList = sha1List.map(sha1 => sha1.substring(0, 6));

const viewCommitOnClick = _sha1List => d => {
// @ts-ignore
window.open(
`https://github.com/denoland/deno/commit/${_sha1List[d["index"]]}`
);
Expand Down Expand Up @@ -233,7 +230,6 @@ export async function drawChartsFromBenchmarkData(dataUrl) {
*/
export async function drawChartsFromTravisData() {
const viewPullRequestOnClick = _prNumberList => d => {
// @ts-ignore
window.open(
`https://github.com/denoland/deno/pull/${_prNumberList[d["index"]]}`
);
Expand Down