Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): add test code lens #10874

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Jun 7, 2021

This PR add support for test code lenses, which allow clients to be able to launch the Deno CLI executing specific tests identified in the IDE.

Extension_Development_Host_-test_ts—_vs_test

@kitsonk kitsonk mentioned this pull request Jun 7, 2021
43 tasks
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no comments, this is a very nice feature 🚀

Comment on lines +513 to +520
let source = r#"
Deno.test({
name: "test a",
fn() {}
});

Deno.test("test b", function anotherTest() {});
"#;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you squeeze in a test for:

const { test } = Deno;

test("test c", function yetAnotherTest() {});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, I see there are other tests like this later in the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the integration test is comprehensive, the unit test is sort of basic.

@kitsonk kitsonk merged commit 3b3be02 into denoland:main Jun 7, 2021
@kitsonk kitsonk deleted the feat_code_lens_test branch June 7, 2021 11:38
Copy link

@1978rumun 1978rumun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants