Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(extensions/timers): better wpt & webidl conformance for performance API #10887

Merged
merged 8 commits into from
Jul 5, 2021
Merged

refactor(extensions/timers): better wpt & webidl conformance for performance API #10887

merged 8 commits into from
Jul 5, 2021

Conversation

crowlKats
Copy link
Member

No description provided.

@lucacasonato lucacasonato self-requested a review June 15, 2021 23:39
@lucacasonato lucacasonato mentioned this pull request Jul 2, 2021
Closed
67 tasks
lucacasonato
lucacasonato reviewed Jul 3, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is now close to green and fixes some WPTs, but I think there is more to fix:

  • add required argument count checks on all constructors and methods
  • webidl convert all parameters for constructors, methods, and setters

@SimonRask SimonRask mentioned this pull request Jul 4, 2021
Merged
lucacasonato
lucacasonato reviewed Jul 4, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments. Very nice though, WPT are now all passing except for ones related to PerformanceObserver (#11260).

extensions/timers/02_performance.js Outdated Show resolved Hide resolved
extensions/timers/02_performance.js Show resolved Hide resolved
crowlKats and others added 2 commits July 5, 2021 04:57
@crowlKats @lucacasonato
Update extensions/timers/02_performance.js
f9676af 
Co-authored-by: Luca Casonato <lucacasonato@yahoo.com>
@crowlKats
fix constructor
2525c66
lucacasonato
lucacasonato approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@lucacasonato lucacasonato merged commit 220104f into denoland:main Jul 5, 2021
@crowlKats crowlKats deleted the performance_webidl branch July 5, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crowlKats @lucacasonato