Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use primordials for extensions/websocket #11240

Merged
merged 8 commits into from
Jul 4, 2021
Merged

refactor: use primordials for extensions/websocket #11240

merged 8 commits into from
Jul 4, 2021

Conversation

littledivy
Copy link
Member

Ref #11224

@littledivy littledivy closed this Jul 3, 2021
@littledivy littledivy reopened this Jul 3, 2021
@lucacasonato lucacasonato mentioned this pull request Jul 3, 2021
Closed
67 tasks
@littledivy littledivy marked this pull request as ready for review July 3, 2021 17:14
@lucacasonato lucacasonato self-requested a review July 3, 2021 17:34
lucacasonato
lucacasonato reviewed Jul 3, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you import Blob from window.__bootstrap.file for line 48?

extensions/websocket/01_websocket.js Outdated Show resolved Hide resolved
bartlomieju
bartlomieju approved these changes Jul 4, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Divy

@bartlomieju bartlomieju merged commit ffd28e7 into denoland:main Jul 4, 2021
@littledivy littledivy deleted the primordials-websocket branch July 4, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@littledivy @lucacasonato @bartlomieju