refactor: use primordials in extensions/fetch #11266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyarohith
force-pushed
the
refactor_fetch
branch
from
b92fcfc
to
b6beb1b
Compare
67 tasks
satyarohith
changed the title
satyarohith
force-pushed
the
refactor_fetch
branch
from
8ac5657
to
b6beb1b
Compare
littledivy
requested changes
Jul 4, 2021
|
@satyarohith Are you not done since it's a draft? |
satyarohith
force-pushed
the
refactor_fetch
branch
from
b6beb1b
to
1862b01
Compare
SimonRask
suggested changes
Jul 5, 2021
There was a problem hiding this comment.
20_headers.js:
- line 299
ArrayPrototypeSplice - line 403
SymbolFor - line 411
SymbolToStringTag - line 423
SymbolIterator
21_formdata.js:
- line 70
SymbolToStringTag
22_body.js:
- line 300
ArrayPrototypeMap - line 340
ArrayPrototypeSlice
23_request.js:
- line 387
SymbolToStringTag - line 391
SymbolFor
23_response.js:
- line 370
SymbolToStringTag - line 374
SymbolFor
26_fetch.js
- line 210
PromisePrototypeCatch - line 220
PromisePrototypeCatch - line 240
PromisePrototypeCatch - line 309
ArrayPrototypeFilter - line 363
ArrayPrototypePush - line 407
ArrayPrototypePush - line 411
PromisePrototypeThen - line 432
PromisePrototypeCatch - line 475
StringPrototypeToLowerCase
satyarohith
force-pushed
the
refactor_fetch
branch
from
1862b01
to
41e5538
Compare
|
Thanks for the thorough review, @SimonRask & @littledivy! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewable commit by commit.
Towards #11224