feat(extensions/crypto): implement verify() for RSA #11312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make sure to update |
lucacasonato
approved these changes
Jul 10, 2021
There was a problem hiding this comment.
JS side LGTM, except a minor comment.
@bnoordhuis could you review the Rust side crypto code?
Co-authored-by: Luca Casonato <lucacasonato@yahoo.com>
bnoordhuis
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1891
Introduces
SubtleCrypto.verifyfor RSA algorithms (RSASSA-PKCS1-v1_5andRSA-PSS)Originally the plan was to implement all current algorithms supported by
sign()in this PR but we can't enable WPT for both the methods because it relies onSubtleCrypto.importKey.