Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow running on 32 bits #11653

Closed
wants to merge 2 commits into from
Closed

feat: allow running on 32 bits #11653

wants to merge 2 commits into from

Conversation

PerfectLaugh
Copy link

@PerfectLaugh PerfectLaugh commented Aug 11, 2021

I find current rusty_v8 is able to compile in 32bits. It would be good to add supports in 32 bit.
Only tested in Windows currently.

For reference:
denoland/rusty_v8#426 (comment)


AaronO leaves a good review on the direction of this pull request.
denoland/serde_v8#16 (review)

We need more platform tests on this issue if we want to release in 32 bits. If not, it should be okay to provide a way compiling to 32 bits also.
Currently tested in my Windows desktop and Linux VM.

@CLAassistant
Copy link

CLAassistant commented Aug 11, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@crowlKats
Copy link
Member

crowlKats commented Aug 12, 2021

As far as I know, GH Actions does not have any 32 bit runners, so we cannot test nor make release binaries for this

@PerfectLaugh
Copy link
Author

And gn binaries do not have i686 architecture either. But it allows to cross compile through CFLAGS

@PerfectLaugh
Copy link
Author

PerfectLaugh commented Aug 12, 2021

image
Tested in Linux also.


Somehow I couldn't pass the error above in whole test but can pass in single test mode.

@piscisaureus
Copy link
Member

@PerfectLaugh is the thiscall calling convention now supported in rust?

@PerfectLaugh
Copy link
Author

@piscisaureus I found there's simply no need to include thiscall. The bindings are turned into extern "C" symbols and no need to assign thiscall except there are changes to callbacks for SystemV i386 ABI.
denoland/rusty_v8#752

@piscisaureus
Copy link
Member

@PerfectLaugh I don’t believe that, but we may be missing a test case.

@bartlomieju bartlomieju modified the milestones: 1.14.0, 1.15.0 Sep 14, 2021
@lucacasonato lucacasonato removed this from the 1.15.0 milestone Oct 11, 2021
@stale
Copy link

stale bot commented Dec 14, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 14, 2021
@stale stale bot closed this Dec 21, 2021
@brandonros
Copy link

Could this be revisited? I need it to do FFI with 32-bit-only DLLs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants