-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow running on 32 bits #11653
Conversation
|
As far as I know, GH Actions does not have any 32 bit runners, so we cannot test nor make release binaries for this |
And gn binaries do not have i686 architecture either. But it allows to cross compile through CFLAGS |
@PerfectLaugh is the thiscall calling convention now supported in rust? |
@piscisaureus I found there's simply no need to include thiscall. The bindings are turned into |
@PerfectLaugh I don’t believe that, but we may be missing a test case. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Could this be revisited? I need it to do FFI with 32-bit-only DLLs |
I find current rusty_v8 is able to compile in 32bits. It would be good to add supports in 32 bit.
Only tested in Windows currently.
For reference:
denoland/rusty_v8#426 (comment)
AaronO leaves a good review on the direction of this pull request.
denoland/serde_v8#16 (review)
We need more platform tests on this issue if we want to release in 32 bits. If not, it should be okay to provide a way compiling to 32 bits also.
Currently tested in my Windows desktop and Linux VM.