Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/crypto): fix copying buffersource #11714

Merged
merged 1 commit into from
Aug 15, 2021
Merged

fix(ext/crypto): fix copying buffersource #11714

merged 1 commit into from
Aug 15, 2021

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Aug 15, 2021 •
edited
Loading

%TypedArray%.prototype.slice cannot be called on ArrayBuffer. This code was unreachable so it never threw, noticed while working on #11642

@bartlomieju bartlomieju merged commit 2d578ea into denoland:main Aug 15, 2021
@littledivy littledivy deleted the fix-buffersource-idlType branch August 15, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littledivy @bartlomieju