Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): correctly parse registry patterns #12063

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Sep 14, 2021

Fixes #10286

There are still some issues with nest.land but I think they are all related to https://github.com/nestdotland/nest.land/issues/320.

Sorry for taking so long to get around to fixing these issues.

@kitsonk
Copy link
Contributor Author

kitsonk commented Sep 14, 2021

MOA

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's a bit hard to follow completion logic due to huge indentation, I'll try to refactor that bit after 1.14

@bartlomieju bartlomieju merged commit d36b01f into denoland:main Sep 14, 2021
@kitsonk kitsonk deleted the kitsonk/issue10265 branch September 14, 2021 12:52
@lucacasonato
Copy link
Member

Thanks for getting this sorted @kitsonk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request.cache throws "TypeError: This property is not implemented."
3 participants