feat(unstable): add lock and unlock methods to Deno.File
#12139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
changed the title
Deno.FileDeno.File
|
I'm not too sure about these tests, but its what the rid based tests do so rolling with it for now. |
dsherret
reviewed
Sep 30, 2021
| import { assertEquals, unitTest } from "./test_util.ts"; | ||
| import { readAll } from "../../../test_util/std/io/util.ts"; | ||
|
|
||
| unitTest( |
There was a problem hiding this comment.
Just a note that these tests are flaky. Perhaps we could update these tests to use the changes in:
https://github.com/denoland/deno/pull/12255/files
Then remove that file and only use this one (since this transitively tests those functions).
|
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
lockandunlockmethods toDeno.Filealong with their sync variants.This inherits being unstable from the ops being unstable.
Towards #12107