Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure first process in shared flock test does not enter and exit lock before second enters #12255

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

dsherret
Copy link
Member

Hopefully fixes #12094 for good. Fix is adding the waitBothEnteredLock: true for this scenario.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit cdac190 into denoland:main Sep 30, 2021
@dsherret dsherret deleted the chore-flakly-flock-tests-part3 branch September 30, 2021 19:45
ry pushed a commit that referenced this pull request Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flock tests are flaky
2 participants