Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ext/webstorage): IndexedDB #14035

Closed
wants to merge 16 commits into from
Closed

Conversation

crowlKats
Copy link
Member

closes #1699

TODO:

  • complete impl
  • typings
  • tests


const request = webidl.createBranded(IDBOpenDBRequest);

(async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps my JS-fu is lacking but what's the point of this async IIFE? It's created, invoked, try-catched and finishes immediately, there is no await point so at least I cannot see anything to this except maybe strack trace differences here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not done yet.

@crowlKats crowlKats requested a review from AaronO as a code owner March 29, 2022 23:24
const value = webidl.converters.BufferSource(input);
return {
type: "binary",
value: value.slice(),
Copy link
Member

@littledivy littledivy Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use primordial. EDIT: Oops looks like its not ready yet. Mark as draft maybe?

Copy link
Member Author

@crowlKats crowlKats Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark as draft maybe?

One of the TODOs in the original comment says "complete impl" 🙃

Comment on lines +173 to +175
keys.find((item) => compareTwoKeys(item, key)) === undefined
) {
keys.push(key);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

}
// TODO: complete implementation
} else if (ArrayIsArray(key)) {
return key.every(isValidKeyPath);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Comment on lines +318 to +320
const identifiers = keyPath.split(".");
assert(identifiers.length !== 0);
identifiers.pop();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Copy link
Member Author

@crowlKats crowlKats Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not doing primordials yet

@stale
Copy link

stale bot commented May 30, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 30, 2022
@crowlKats crowlKats removed the stale label May 30, 2022
@stale
Copy link

stale bot commented Sep 20, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 20, 2022
@crowlKats crowlKats removed the stale label Sep 21, 2022
@crowlKats crowlKats closed this Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for IndexedDB
3 participants